Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetup json output, minor fixes #6339

Merged
merged 2 commits into from
Apr 6, 2025
Merged

Conversation

bdillo
Copy link
Contributor

@bdillo bdillo commented Feb 2, 2025

This fixes some of the event location capitalization issues. The meetup API returns strings like "San francisco", so this fix will format these things a bit more correctly. Also in GB part of the postal code was used as the state, this is ignored now. Additionally, the meetup API returns an empty string if a part of a location is missing, which we now switch to None.

This also adds a way to output the events as json so they can be used in further automation. Currently we're just merging the lists together manually, having a better output format to use will let us create other tools to merge the lists together and save us some time.

Change was tested manually, example json partial output:

{"Virtual": [{"name": "Indy.rs - with Social Distancing", "location": "Indianapolis, IN, US", "date": "2025-02-05", "url": "https://www.meetup.com/indyrs/events/302031658", "virtual": true, "organizer_name": "Indy Rust", "organizer_url": "https://www.meetup.com/indyrs/events/"}, ...

@bdillo bdillo requested a review from mariannegoldin February 2, 2025 01:46
@bdillo bdillo self-assigned this Feb 2, 2025
@bennyvasquez
Copy link
Contributor

I'm going through PRs in prep for this week's edition. I'm not at all qualified to review this one (which is why you didn't ask me to!) but I'm excited for it nonetheless! We'll leave it for @mariannegoldin. :D

@mariannegoldin
Copy link
Contributor

Hi all: I still need to review this; thanks for your patience.

@mariannegoldin
Copy link
Contributor

Hi @bdillo - manually tested, and works great.

Is the intention to run the script over maybe-rust-meetups.json and rust-meetups.json and then manually collate the results?

Copy link
Contributor

@mariannegoldin mariannegoldin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this time saving improvement!

@bdillo
Copy link
Contributor Author

bdillo commented Apr 6, 2025

Hi @bdillo - manually tested, and works great.

Is the intention to run the script over maybe-rust-meetups.json and rust-meetups.json and then manually collate the results?

for now yes, I'll probably just add a basic check to see if the string "rust" (case insensitive) shows up in the maybe-rust meetup groups

@bdillo bdillo merged commit c867ff9 into rust-lang:master Apr 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants